Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] update apps_layout.csv from EPSILON_APPS flag in make command #341

Open
wants to merge 2 commits into
base: upsilon-dev
Choose a base branch
from

Conversation

AngeDieu
Copy link

I did it ! It's my first real modification of Upsilon (and of any c++ project) ! 🎉

I fixed a bug :
When you buid Upsilon changing the app order with the EPSILON_APPS flag, the layout stayed the old one, and the app you clicked on wasn't the shown one.
It's easier to understand with screenshots:
image
and when I click on it, it opens the python app !
image

To fix it, the apps_layout.csv is automaticly updated from the EPSILON_APPS flag in the make command.

The Default and HidePython layouts are both updated because of the same bug: the layout and the content of the home app isn't synchronized (pressing the graph icon doen't mean go to the graph icon, but go to the app n°x, which can be different from the graph app).

@AngeDieu
Copy link
Author

I just renamed the branch

@github-actions
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 822196 bytes 477549 bytes 226520 bytes 1816 bytes 228336 bytes 1301561 bytes
Head 822196 bytes 477549 bytes 226520 bytes 1816 bytes 228336 bytes 1301561 bytes
+0 bytes +0 bytes +0 bytes +0 bytes +0 bytes +0 bytes
+0.0 % +0.0 % +0.0 % +0.0 % +0.0 % +0.0 %

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant